Fifesoft

Vicne wrote:I guess there is something else in my code refreshing the view regularly that interferes with the setCaretPosition() in markAll()... I'm having a look.

I believe the darker yellow colored region is the default "mark all" color. I think the problem here is twofold. First, you still have the default mark occurrences functionality enabled, which you don't want to do since you're providing your own substitute functionality with MarkAllOccurrencesSupport. Not really a problem, but something to note.

The second problem is a bug in the code snippet I provided earlier.
Note the bug was that the second parameter to JTextComponent.getText(int start, int len) is the length of the string to get, not the end offset.

Hope this helps!

Code: Select all

public void actionPerformed(ActionEvent e) {

    textArea.clearMarkAllHighlights();
    if (c.getDot()!=c.getMark()) {
       return;
    }

    try {
       int start = Utilities.getWordStart(textArea, c.getDot());
       int end = Utilities.getWordEnd(textArea, c.getDot());
       String word = textArea.getText(start, end-start+1); // May need to be just (end-start), not sure
       textArea.markAll(word, false, true, false);
    } catch (BadLocationException ble) {
       ble.printStackTrace();
    }

}


robert wrote:Rather than subclassing MarkOccurrencesSupport (I see now that you need access to the private field "p"), you could make a copy of it and name it MarkAllOccurrencesSupport, and change just the actionPerformed() method.

Then, rather than modifying RSyntaxTextArea so its MarkOccurrencesSupport is your copy, simply install yours from the outside:

Code: Select all

MarkAllOccurrencesSupport support = new MarkAllOccurrencesSupport();
support.install(textArea);


Code: Select all

MarkAllOccurrencesSupport support = new MarkAllOccurrencesSupport();
support.install(textArea);


robert wrote:It sounds like what you really want is "mark all" perhaps?

You'd basically want to clone the org.fife.ui.rsyntaxtextarea.MarkOccurrencesSupport class, since it handles imposing a delay with no caret changes before changing the highlights. You'd just change the actionPerformed() method to be something like this: (...)
Does that sound like it'll fit your needs?

Code: Select all

int markAll(String toMark, boolean matchCase, boolean wholeWord, boolean regex);
void clearMarkAllHighlights();
void setMarkAllHighlightColor(Color color);


Code: Select all

public void actionPerformed(ActionEvent e) {

   textArea.clearMarkAllHighlights();
   if (c.getDot()!=c.getMark()) {
      return;
   }

   try {
      int start = Utilities.getWordStart(textArea, c.getDot());
      int end = Utilities.getWordEnd(textArea, c.getEnd());
      String word = textArea.getText(start, end); // May need to be end+1, not sure
      textArea.markAll(word, false, true, false);
   } catch (BadLocationException ble) {
      ble.printStackTrace();
   }

}